[llvm_instcount] Leaderboard Submission: DQN trained on test set #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csv file along with writeup to leaderboard/llvm_instcount/dqn
facebook-github-bot
added
the
CLA Signed
ChrisCummins
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Hi @phesse001, nice submission!
Could you add a little bit of an explanation to the "What range of values were considered for the above parameters?" section of the write up to describe how you arrived at those values? E.g. was it by trial and error, what was the experimental setup for each "trial". Just a sentence or two would be enough :)
Other than that, looks great. A few minor nitpick comments left inline.
I have reproduced your results locally, so this is me signing off on your results! Once you've had a chance to take a look at those small things I'd say this is looking good to merge.
$ python -m compiler_gym.bin.validate --env=llvm-ic-v0 CompilerGym/results.csv
✅ cbench-v1/rijndael 1.1027
✅ cbench-v1/adpcm 1.0084
✅ cbench-v1/adpcm 1.0084
✅ cbench-v1/adpcm 1.0084
✅ cbench-v1/ispell 0.9887
✅ cbench-v1/rijndael 1.1027
✅ cbench-v1/rijndael 1.1027
...
✅ cbench-v1/tiffmedian 1.0324
----------------------------------------------------
Number of validated results: 230 of 230
Mean walltime per benchmark: 0.367s (std: 0.781s)
Geometric mean IrInstructionCountOz: 1.029 (std: 0.112)Cheers,
Chris
Co-authored-by: Chris Cummins <chrisc.101@gmail.com>
…t commit rather than branch Co-authored-by: Chris Cummins <chrisc.101@gmail.com>
|
LGTM, thanks @phesse001! |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the results of training a dqn on the benchmarks from the test set (cbench-v1) for 4000 episodes using the llvm-ic-v0 environment with InstCountNorm as the observation passed to the dqn.
The trained model was then saved and loaded for evaluation of the policy. Since this is not a general policy, I timed the training process with the
timecommand and got a total of 2085.99s. I averaged this over the 23 benchmarks, getting ~90.700s per benchmark, and added the average walltime of .318s from eval_llvm_instcount_policy() to get a total of 91.018s walltime(mean).My code for the dqn can be found here
What is in this PR?